Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix realesrnet test dataset #1489

Merged
merged 1 commit into from
Nov 30, 2022
Merged

[Fix] fix realesrnet test dataset #1489

merged 1 commit into from
Nov 30, 2022

Conversation

Z-Fran
Copy link
Collaborator

@Z-Fran Z-Fran commented Nov 30, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

fix realesrnet test dataset

Modification

fix realesrnet test dataset

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@Z-Fran Z-Fran requested a review from zengyh1900 November 30, 2022 07:21
@Z-Fran Z-Fran self-assigned this Nov 30, 2022
@Z-Fran Z-Fran changed the title [FIx] fix realesrnet test dataset [Fix] fix realesrnet test dataset Nov 30, 2022
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 83.89% // Head: 83.90% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (693736a) compared to base (ad2fb76).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1489      +/-   ##
==========================================
+ Coverage   83.89%   83.90%   +0.01%     
==========================================
  Files         224      224              
  Lines       12771    12771              
  Branches     1994     1994              
==========================================
+ Hits        10714    10716       +2     
+ Misses       1717     1716       -1     
+ Partials      340      339       -1     
Flag Coverage Δ
unittests 83.90% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/datasets/pipelines/random_degradations.py 94.01% <0.00%> (ø)
...ls/components/stylegan2/generator_discriminator.py 90.96% <0.00%> (+1.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zengyh1900 zengyh1900 merged commit 1e7e3d1 into master Nov 30, 2022
@zengyh1900 zengyh1900 deleted the fix-realesrnet branch November 30, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants