Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could evaluation hook use key_indicator in a case-insensitive manner? #1065

Closed
ly015 opened this issue May 31, 2021 · 3 comments
Closed

Could evaluation hook use key_indicator in a case-insensitive manner? #1065

ly015 opened this issue May 31, 2021 · 3 comments
Assignees
Labels

Comments

@ly015
Copy link
Member

ly015 commented May 31, 2021

Would it be better to use key_indicator.lower() to infer the rule in a case-insensitive manner? E.g., "MAP" and "mAP" would both be okay, so the user won't have to pay attention to it.

if rule is None:

@zhouzaida
Copy link
Collaborator

@dreamerlin

@ly015
Copy link
Member Author

ly015 commented Jun 3, 2021

A PR #1076 has been submitted for this.

@zhouzaida zhouzaida added the WIP label Jun 10, 2021
@zhouzaida
Copy link
Collaborator

Resolved by #1076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants