Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The amount of user-configurable templates is becoming hard to manage #4836

Open
sergei-maertens opened this issue Nov 19, 2024 · 1 comment
Labels
enhancement topic: cleanup topic: tech debt topic: templates Templates/sjablonen die door beheerders ingesteld kunnen worden

Comments

@sergei-maertens
Copy link
Member

sergei-maertens commented Nov 19, 2024

Open Form allows admins/form designers to configure a number of templates that are rendered at certain stages of a form submission, such as (but not limited to):

  • confirmation email (global config / form-specific overrides)
  • cosign request email
  • confirmation page content
  • cosign confirmation page content
  • introduction page
  • start page body text

It's becoming hard to keep the overview of which templates are available and in which cases they get rendered, and there's now also branching being added for templates for forms with/without cosign. If we follow this pattern e.g. for submissions with/without payment requirement, the possible combinations explode (with/without cosign + with/without payment -> 4 template fields, each localized in 2 languages -> 8 DB columns (!))

Additionally, loading a WYSIWYG editor in the admin for each template field adds quite some overhead to the page (in terms of memory and CPU footprint).

A better solution to manage user templates should be investigated.

See also thoughts in comment

@sergei-maertens sergei-maertens added triage Issue needs to be validated. Remove this label if the issue considered valid. topic: cleanup topic: tech debt topic: templates Templates/sjablonen die door beheerders ingesteld kunnen worden labels Nov 19, 2024
@joeribekker joeribekker added big topic enhancement and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Dec 2, 2024
@joeribekker
Copy link
Contributor

This is good to pick up when we add yet another template...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement topic: cleanup topic: tech debt topic: templates Templates/sjablonen die door beheerders ingesteld kunnen worden
Projects
Status: Todo
Development

No branches or pull requests

2 participants