Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally hide component #54

Merged
merged 9 commits into from
Jan 24, 2025

Conversation

sergei-maertens
Copy link
Member

@sergei-maertens sergei-maertens commented Dec 28, 2024

Partly closes #59

  • Prototype simple case
  • Support layout components & nested components

@sergei-maertens sergei-maertens force-pushed the feature/conditionally-hide-component branch 5 times, most recently from 8b822f9 to 55a7fbf Compare January 11, 2025 20:39
@sergei-maertens sergei-maertens force-pushed the feature/conditionally-hide-component branch from 55a7fbf to 9dd4792 Compare January 23, 2025 22:06
Certain behaviours are expected to match the reference implementation.

We can define stories in a way that one is renderer with our
implementation, and another is rendered with the reference Formio.js
SDK, with the versions used in the Open Forms SDK. This way, we
guarantee that our (interaction) tests are written correctly by
validating the Formio behaviour, and these same tests are then used
to validate the behaviour of our own implementation.
@sergei-maertens sergei-maertens force-pushed the feature/conditionally-hide-component branch from aa3d4af to 613e535 Compare January 24, 2025 22:04
@sergei-maertens sergei-maertens force-pushed the feature/conditionally-hide-component branch from 613e535 to 564e704 Compare January 24, 2025 22:08
@sergei-maertens sergei-maertens marked this pull request as ready for review January 24, 2025 23:00
@sergei-maertens sergei-maertens merged commit 186fd83 into main Jan 24, 2025
6 checks passed
@sergei-maertens sergei-maertens deleted the feature/conditionally-hide-component branch January 24, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support simple conditional logic
1 participant