-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add targeted Flag to example config #467
Conversation
Adding a new flag because in open-feature/killercoda#5 I'm trying to explain targeting. This example is explicit in that: - Everyone gets `first` except - Those with `email` containing `@openfeature.dev` - get `second` - Those with `userAgent` containing `Chrome` - get `third`. Signed-off-by: Adam Gardner <adam@agardner.net>
Codecov Report
@@ Coverage Diff @@
## main #467 +/- ##
=======================================
Coverage 62.12% 62.12%
=======================================
Files 13 13
Lines 1650 1650
=======================================
Hits 1025 1025
Misses 562 562
Partials 63 63 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Adam Gardner <adam@agardner.net>
Signed-off-by: Adam Gardner <adam@agardner.net>
I've also added (what I think) is the correct YAML definition. Please do check that closely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The YAML looked wrong. I used the JSON to YAML converter to generate the suggested changes.
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Adam Gardner <adam@agardner.net>
🤖 I have created a release *beep* *boop* --- ## [0.4.2](v0.4.1...v0.4.2) (2023-03-09) ### 🧹 Chore * Add targeted Flag to example config ([#467](#467)) ([6a039ce](6a039ce)) * **deps:** pin dependencies ([#473](#473)) ([679e860](679e860)) * **deps:** update google-github-actions/release-please-action digest to e0b9d18 ([#474](#474)) ([5b85b2a](5b85b2a)) * refactoring and improve coverage for K8s Sync ([#466](#466)) ([6dc441e](6dc441e)) ### 🐛 Bug Fixes * add registry login ([#476](#476)) ([99de755](99de755)) * **deps:** update module golang.org/x/crypto to v0.7.0 ([#472](#472)) ([f53f6c8](f53f6c8)) * **deps:** update module google.golang.org/protobuf to v1.29.0 ([#478](#478)) ([f9adc8e](f9adc8e)) ### ✨ New Features * grpc tls connectivity (grpcs) ([#477](#477)) ([228f430](228f430)) * introduce per-sync configurations ([#448](#448)) ([1d80039](1d80039)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Adding a new flag because in open-feature/killercoda#5 I'm trying to explain targeting.
This example is explicit in that:
first
exceptemail
containing@openfeature.dev
- getsecond
userAgent
containingChrome
- getthird
.