fix: set ResolveObject reason #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
skyerus
requested review from
AlexsJones,
james-milligan and
toddbaert
as code owners
toddbaert
approved these changes
Feb 6, 2023
beeme1mr
approved these changes
Feb 6, 2023
|
I think another reason this happened is there's some duplicated code here. If there's any way to "genericize" these functions, we should do it. If not, we still might be able to extract SOME repeated code into functions. |
toddbaert
pushed a commit
that referenced
this pull request
Feb 6, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.6](v0.3.5...v0.3.6) (2023-02-06) ### Bug Fixes * set ResolveObject reason ([#375](#375)) ([dcf199d](dcf199d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Discovered as integration tests PR started failing. In future this kind of thing will be picked up as a pipeline failure (all the more reason to get to the bottom of the snyk security issue).
Related Issues
Notes
Follow-up Tasks
How to test