Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bubbles up unclean error exits #170

Merged
merged 2 commits into from
Sep 23, 2022
Merged

fix: bubbles up unclean error exits #170

merged 2 commits into from
Sep 23, 2022

Conversation

AlexsJones
Copy link
Member

@AlexsJones AlexsJones commented Sep 22, 2022

Signed-off-by: Alex Jones alexsimonjones@gmail.com

#169

Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@beeme1mr
Copy link
Member

Hey @AlexsJones, can you update the PR title to start with fix instead of chore? That will ensure the change properly bumps the version and is included in the release notes.

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me. Agree with @beeme1mr this should be a fix so it goes into the changelog automatically though.

@AlexsJones AlexsJones changed the title chore: bubbles up unclean error exits fix: bubbles up unclean error exits Sep 23, 2022
@AlexsJones AlexsJones merged commit 9f7db02 into main Sep 23, 2022
@AlexsJones AlexsJones deleted the chore/flagd-exits branch September 23, 2022 07:55
AlexsJones pushed a commit that referenced this pull request Sep 23, 2022
🤖 I have created a release *beep* *boop*
---


##
[0.1.1](v0.1.0...v0.1.1)
(2022-09-23)


### Bug Fixes

* bubbles up unclean error exits
([#170](#170))
([9f7db02](9f7db02))
* upgrade package containing vulnerability
([#162](#162))
([82278c7](82278c7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants