feat: only fire modify event when FeatureFlagConfiguration Generation field has changed

[skyerus]

Signed-off-by: Skye Gill gill.skye95@gmail.com

[skyerus]

This field changes when FeatureFlagConfiguration has been updated in some way

[AlexsJones]

Have you tested this? I had this in the original implementation but issues ever getting it to work.

[skyerus]

Have you tested this? I had this in the original implementation but issues ever getting it to work.

Confirmed that this works for me. There is a slight delay in the update but there always was, right? Or did the delay get fixed at some point?

[AlexsJones]

Have you tested this? I had this in the original implementation but issues ever getting it to work.

Confirmed that this works for me. There is a slight delay in the update but there always was, right? Or did the delay get fixed at some point?

Are we talking 5 seconds? Because that's the cache refresh time

[skyerus]

Have you tested this? I had this in the original implementation but issues ever getting it to work.

Confirmed that this works for me. There is a slight delay in the update but there always was, right? Or did the delay get fixed at some point?

Are we talking 5 seconds? Because that's the cache refresh time

No, closer to a minute sadly.

[AlexsJones]

Have you tested this? I had this in the original implementation but issues ever getting it to work.

Confirmed that this works for me. There is a slight delay in the update but there always was, right? Or did the delay get fixed at some point?

Are we talking 5 seconds? Because that's the cache refresh time

No, closer to a minute sadly.

Interestingly that's the issue I had - I think the notifier has different update cycles based on whether it's the metadata update versus the spec itself. Can I test your changes before we go further? I will try and figure out if there is something we can tweak in the notifier itself.

[skyerus]

Have you tested this? I had this in the original implementation but issues ever getting it to work.

Confirmed that this works for me. There is a slight delay in the update but there always was, right? Or did the delay get fixed at some point?

Are we talking 5 seconds? Because that's the cache refresh time

No, closer to a minute sadly.

Interestingly that's the issue I had - I think the notifier has different update cycles based on whether it's the metadata update versus the spec itself. Can I test your changes before we go further? I will try and figure out if there is something we can tweak in the notifier itself.

Sounds good, I'll have a play around too.

[AlexsJones]

I will do this, but might need a few days till I get time

[skyerus]

I will do this, but might need a few days till I get time

I was able to get it working @AlexsJones 🎉

Tested alongside OFO, with this change the event is emitted immediately & exclusively when a change occurs.