Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support azure blob sync #1428

Merged
merged 1 commit into from
Oct 23, 2024
Merged

feat: support azure blob sync #1428

merged 1 commit into from
Oct 23, 2024

Conversation

wilson-matthew
Copy link
Contributor

This PR

  • adds support for Azure Blob Storage sync

How to test

  • create an Azure Storage Account and a container with a flags definition file inside
  • set AZURE_STORAGE_ACCOUNT env var to the name of the storage account
  • set AZURE_STORAGE_KEY env var to the access key of the storage account, or use another authentication method: https://pkg.go.dev/gocloud.dev/blob/azureblob#hdr-URLs
  • start flagd with the --uri flag set to azblob://my-container/my-flags.json

@wilson-matthew wilson-matthew requested a review from a team as a code owner October 21, 2024 15:55
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 21, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

✅ Deploy Preview for polite-licorice-3db33c ready!

Name Link
🔨 Latest commit 9e98688
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/67167daa87829100086c15d7
😎 Deploy Preview https://deploy-preview-1428--polite-licorice-3db33c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wilson-matthew
feat: support azure blob sync
9e98688 
Signed-off-by: Matthew Wilson <54033231+wilson-matthew@users.noreply.github.com>
beeme1mr
beeme1mr reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'd like to test it out manually before giving a final approval, but it looks good so far. Also, nice job catching all those doc inconsistencies.

@beeme1mr
Copy link
Member

Hey @wilson-matthew, I'm new to Azure, so please bear with me. I tried to test using a SAS token but ran into a 403. The environment variable I set was AZURE_STORAGE_SAS_TOKEN, which appears to be supported by the blob library. Do you have any idea what's happening, or should I try a different auth mechanism?

@wilson-matthew
Copy link
Contributor Author

Hey @beeme1mr, I just tested using a SAS token with the AZURE_STORAGE_SAS_TOKEN environment variable and it worked okay for me. What settings did you use when generating the SAS token - I wonder if it didn’t have the correct permissions? You could try the AZURE_STORAGE_KEY auth mechanism as that is unlikely to have a permissions issue.

beeme1mr
beeme1mr approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it working, thanks!

toddbaert
toddbaert approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks a lot!

@toddbaert toddbaert merged commit 5c39cfe into open-feature:main Oct 23, 2024
15 checks passed
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
Merged
pradeepbbl pushed a commit to bookingcom/flagd that referenced this pull request Oct 28, 2024
@wilson-matthew @pradeepbbl
feat: support azure blob sync (open-feature#1428)
9ca22b3 
- adds support for Azure Blob Storage sync

Signed-off-by: Matthew Wilson <54033231+wilson-matthew@users.noreply.github.com>
pradeepbbl pushed a commit to bookingcom/flagd that referenced this pull request Oct 28, 2024
@wilson-matthew @pradeepbbl
feat: support azure blob sync (open-feature#1428)
813292f 
- adds support for Azure Blob Storage sync

Signed-off-by: Matthew Wilson <54033231+wilson-matthew@users.noreply.github.com>
beeme1mr pushed a commit that referenced this pull request Oct 28, 2024
@github-actions
chore: release main (#1412)
df54b66 
🤖 I have created a release *beep* *boop*
---


<details><summary>flagd: 0.11.4</summary>

##
[0.11.4](flagd/v0.11.3...flagd/v0.11.4)
(2024-10-28)


### 🐛 Bug Fixes

* **deps:** update module
buf.build/gen/go/open-feature/flagd/connectrpc/go to
v1.17.0-20240906125204-0a6a901b42e8.1
([#1409](#1409))
([f07d348](f07d348))
* **deps:** update module
buf.build/gen/go/open-feature/flagd/protocolbuffers/go to
v1.35.1-20240906125204-0a6a901b42e8.1
([#1420](#1420))
([1f06d5a](1f06d5a))
* **deps:** update module github.com/open-feature/flagd/core to v0.10.3
([#1411](#1411))
([a312196](a312196))
* **deps:** update module github.com/prometheus/client_golang to v1.20.5
([#1425](#1425))
([583ba89](583ba89))
* **deps:** update module go.uber.org/mock to v0.5.0
([#1427](#1427))
([0c6fd7f](0c6fd7f))
* **deps:** update module golang.org/x/net to v0.30.0
([#1417](#1417))
([4d5b75e](4d5b75e))
* **deps:** update module google.golang.org/grpc to v1.67.1
([#1415](#1415))
([85a3a6b](85a3a6b))


### ✨ New Features

* added custom grpc resolver
([#1424](#1424))
([e5007e2](e5007e2))
* support azure blob sync
([#1428](#1428))
([5c39cfe](5c39cfe))
</details>

<details><summary>flagd-proxy: 0.6.7</summary>

##
[0.6.7](flagd-proxy/v0.6.6...flagd-proxy/v0.6.7)
(2024-10-28)


### 🐛 Bug Fixes

* **deps:** update module
buf.build/gen/go/open-feature/flagd/protocolbuffers/go to
v1.35.1-20240906125204-0a6a901b42e8.1
([#1420](#1420))
([1f06d5a](1f06d5a))
* **deps:** update module github.com/open-feature/flagd/core to v0.10.3
([#1411](#1411))
([a312196](a312196))
* **deps:** update module github.com/prometheus/client_golang to v1.20.5
([#1425](#1425))
([583ba89](583ba89))
* **deps:** update module golang.org/x/net to v0.30.0
([#1417](#1417))
([4d5b75e](4d5b75e))
* **deps:** update module google.golang.org/grpc to v1.67.1
([#1415](#1415))
([85a3a6b](85a3a6b))
</details>

<details><summary>core: 0.10.4</summary>

##
[0.10.4](core/v0.10.3...core/v0.10.4)
(2024-10-28)


### 🐛 Bug Fixes

* **deps:** update module
buf.build/gen/go/open-feature/flagd/protocolbuffers/go to
v1.35.1-20240906125204-0a6a901b42e8.1
([#1420](#1420))
([1f06d5a](1f06d5a))
* **deps:** update module github.com/prometheus/client_golang to v1.20.5
([#1425](#1425))
([583ba89](583ba89))
* **deps:** update module go.uber.org/mock to v0.5.0
([#1427](#1427))
([0c6fd7f](0c6fd7f))
* **deps:** update module gocloud.dev to v0.40.0
([#1422](#1422))
([e0e4709](e0e4709))
* **deps:** update module golang.org/x/crypto to v0.28.0
([#1416](#1416))
([fb272da](fb272da))
* **deps:** update module google.golang.org/grpc to v1.67.1
([#1415](#1415))
([85a3a6b](85a3a6b))


### ✨ New Features

* added custom grpc resolver
([#1424](#1424))
([e5007e2](e5007e2))
* support azure blob sync
([#1428](#1428))
([5c39cfe](5c39cfe))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@toddbaert toddbaert toddbaert approved these changes

Assignees
No one assigned
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wilson-matthew @beeme1mr @toddbaert