feat: Add dx to catch ConfigureAwait(false) #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjiro
force-pushed
the
feat/enable-ca2007-analyzer-rule
branch
from
96469b1
to
ade7f82
Compare
- Enable dotnet anaylzers - Ignore rule in benchmarks/tests Signed-off-by: Benjamin Evenson <2031163+benjiro@users.noreply.github.com>
benjiro
force-pushed
the
feat/enable-ca2007-analyzer-rule
branch
from
ade7f82
to
3fec80a
Compare
benjiro
commented
Sep 20, 2023
| @@ -12,6 +13,7 @@ namespace OpenFeature.Benchmark | |||
| [SimpleJob(RuntimeMoniker.Net60, baseline: true)] | |||
| [JsonExporterAttribute.Full] | |||
| [JsonExporterAttribute.FullCompressed] | |||
| [SuppressMessage("Reliability", "CA2007:Consider calling ConfigureAwait on the awaited task")] | |||
There was a problem hiding this comment.
Adding ConfigureAwait is pointless in the testing suite.
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
=======================================
Coverage 93.91% 93.91%
=======================================
Files 20 20
Lines 542 542
Branches 39 39
=======================================
Hits 509 509
Misses 20 20
Partials 13 13 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
beeme1mr
approved these changes
Sep 20, 2023
|
@benjiro Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Stop #149 happening again in the future
Notes
N/A
Follow-up Tasks
N/A
How to test
N/A