Custom UI for a specific client #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The sidebar will house the filtering of the enrollments. So the CourseEnrollments component should have access to it. - Adds support to no-enrollments scenario by hiding the sidebar.
This reverts commit c499623.
- set max height to avoid cover images stretching the card - adds some margin below card stack - switch from horizontal to vertical card on smaller screens
Earlier the card border was only used for the card-body. This became awkward when orientaiton was switched to vertical in smaller screens. This commit moves the border to the card itself so both orientations can have a consistent top accent bar.
Not sure of the reasons, client asked for it.
- set background to white across the board - moved the pills on the cards above course name - adds a Learn More button to the card in its Footer
- image on the left - max height of image set to 460px to prevent long portrait images stretching out the header - breadcrumb moved out of the content area into it's own row - hide the "program" information - align the text and button content to center of the div
The icons used in the Figma designs are from material symbols. So, a npm package that provides them as SVGs is added a dependency to the MFE and the correct book icon and the in-progress icons are used.
This doesn't seems to play nice with the themed footer creating overlap of content and footer.
The enrollment failure URLs were using the React Router's location.pathname, which omits the basename when the MFE is deployed in a sub-directory. This commit instead uses the global.location.pathname (browser location api) to make sure that the full path including the sub-directory is used.
3 tasks
|
Closing this as this was an adhoc customization done for a quick deployment. We will pursue generic customization separately. |
|
NOTE: Do not delete the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all changes
Only if submitting a visual change