Job should fail if Collect yields no files/file items

[jpmckinney]

I'll leave #29 open for longer term quality assurance.

Presently, if Collect yields only errors, then Process never finishes.

I'll have a look at Process to see if it can finish despite receiving no workable data (might be in "completable" function).

That said, once all tasks are complete, the job status should be failed.

[jpmckinney]

Can test with Buenos Aires, currently. Edit: And now with nigeria_portal (all requests were 503).

[jpmckinney]

• Kingfisher Collect increments kingfisher_process_expected_files_count for both File and FileError. Let's say only FileError's are sent.
• Kingfisher Process creates a CollectionFile for FileError's. It creates a note, but otherwise it doesn't create any further rows.
• Kingfisher Process's compilable function would return True if expected_files_count were 0. As it's not, it then checks the collection's data_type. Since only FileError's were received, the data_type isn't set, so it returns False.

[jpmckinney]

Okay, I've made changes to Collect and Process such that errors aren't counted.

We can now see our first failed empty collection: https://data.open-contracting.org/admin/data_registry/job/2190/change/?_changelist_filters=status__exact%3DRUNNING