Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WithAgentHealthProber(...) should pass ManagedClusterAddon to correctly detect agent namespace #221

Open
tamalsaha opened this issue Nov 5, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@tamalsaha
Copy link
Contributor

Currently WithAgentHealthProber() does not have access to the agent namespace. This is required for workapi type prober to correctly identify the workloads for a given cluster.

@qiujian16 qiujian16 added the bug Something isn't working label Mar 6, 2024
@qiujian16
Copy link
Member

/assign @qiujian16

@qiujian16
Copy link
Member

@zhiweiyin318 I think with the recent change on addon-framework, this has been resolved? Would you help to check?

@zhiweiyin318
Copy link
Member

yes, we have added a new func in WorkHealthProber which can pass addon .

type AddonHealthCheckerFunc func([]FieldResult, *clusterv1.ManagedCluster, *addonapiv1alpha1.ManagedClusterAddOn) error

@tamalsaha please try this new func.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants