Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redirection): ensure nonce is used correctly #728

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Conversation

rsdmike
Copy link
Member

@rsdmike rsdmike commented Nov 15, 2022

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #728 (9507209) into main (42d8fb3) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9507209 differs from pull request most recent head 58a15ae. Consider uploading reports for the commit 58a15ae to get more accurate results

@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
- Coverage   93.36%   93.35%   -0.01%     
==========================================
  Files          78       78              
  Lines        3284     3283       -1     
  Branches      528      526       -2     
==========================================
- Hits         3066     3065       -1     
  Misses        218      218              
Impacted Files Coverage Δ
src/utils/redirectInterceptor.ts 100.00% <100.00%> (ø)
src/amt/HttpHandler.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rsdmike rsdmike enabled auto-merge (squash) November 15, 2022 20:27
@rsdmike rsdmike merged commit 76a7c80 into main Nov 15, 2022
@rsdmike rsdmike deleted the redirectionFix branch November 15, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants