Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Security): variable to set minimum TLS version #611

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Conversation

vinayg-intel
Copy link
Contributor

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

@vinayg-intel vinayg-intel requested review from rsdmike and removed request for rsdmike May 13, 2022 15:42
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #611 (cf0a0b6) into main (dbc8f13) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #611   +/-   ##
=======================================
  Coverage   92.96%   92.96%           
=======================================
  Files          71       71           
  Lines        3069     3069           
  Branches      499      499           
=======================================
  Hits         2853     2853           
  Misses        216      216           
Impacted Files Coverage Δ
src/index.ts 50.00% <0.00%> (ø)
src/utils/certificates.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc8f13...cf0a0b6. Read the comment docs.

@vinayg-intel vinayg-intel requested a review from rsdmike May 13, 2022 16:09
@rsdmike
Copy link
Member

rsdmike commented May 18, 2022

please squash your commits

@vinayg-intel
Copy link
Contributor Author

please squash your commits

Done. Thanks for the help

Copy link
Member

@rsdmike rsdmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the minVersion set to TLS1 when thats not a valid option. Can we add validation to the field and ensure that a correct version has been provided?

@vinayg-intel vinayg-intel merged commit 4657e06 into main Jun 17, 2022
@rsdmike rsdmike deleted the TLSminVersion branch June 17, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants