-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Security): variable to set minimum TLS version #611
Conversation
Codecov Report
@@ Coverage Diff @@
## main #611 +/- ##
=======================================
Coverage 92.96% 92.96%
=======================================
Files 71 71
Lines 3069 3069
Branches 499 499
=======================================
Hits 2853 2853
Misses 216 216
Continue to review full report at Codecov.
|
please squash your commits |
6cea48a
to
ec78f44
Compare
Done. Thanks for the help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is the minVersion set to TLS1 when thats not a valid option. Can we add validation to the field and ensure that a correct version has been provided?
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )