Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(auth): test device auth #246

Merged
merged 3 commits into from
Jun 16, 2021
Merged

test(auth): test device auth #246

merged 3 commits into from
Jun 16, 2021

Conversation

brianosburn-intel
Copy link
Contributor

No description provided.

Copy link
Member

@rsdmike rsdmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests for getAmtPassword ?

@codecov-commenter
Copy link

Codecov Report

Merging #246 (134d002) into master (51e07d0) will increase coverage by 0.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
+ Coverage   26.95%   27.61%   +0.66%     
==========================================
  Files          54       55       +1     
  Lines        3513     3552      +39     
  Branches      658      661       +3     
==========================================
+ Hits          947      981      +34     
- Misses       2286     2291       +5     
  Partials      280      280              
Impacted Files Coverage Δ
src/utils/AuthDbProvider.ts 87.17% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e07d0...134d002. Read the comment docs.

Copy link
Member

@rsdmike rsdmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better! woot woot! Look at that > 80%+ coverage! Can take it even higher if we wanna cover those error cases ;)

@brianosburn-intel brianosburn-intel merged commit a1c1902 into master Jun 16, 2021
@brianosburn-intel brianosburn-intel deleted the auth_tests branch June 16, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants