feat(reverseproxy): updated DB amd api's to store the connection status #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhavilosetty-intel
requested review from
rsdmike and
brianosburn-intel
and removed request for
rsdmike and
brianosburn-intel
madhavilosetty-intel
force-pushed
the
mps-reverse-proxy
branch
5 times, most recently
from
3583e85
to
edaa834
Compare
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
- Coverage 25.20% 24.84% -0.37%
==========================================
Files 61 57 -4
Lines 4086 4094 +8
Branches 752 765 +13
==========================================
- Hits 1030 1017 -13
- Misses 2776 2797 +21
Partials 280 280
Continue to review full report at Codecov.
|
madhavilosetty-intel
force-pushed
the
mps-reverse-proxy
branch
3 times, most recently
from
e64f734
to
022297b
Compare
rsdmike
requested changes
May 14, 2021
madhavilosetty-intel
force-pushed
the
mps-reverse-proxy
branch
from
022297b
to
33674d7
Compare
| try { | ||
| const errors = validationResult(req) | ||
| if (!errors.isEmpty()) { | ||
| res.status(400).json({ errors: errors.array() }) |
There was a problem hiding this comment.
should this have a .end()
brianosburn-intel
approved these changes
May 19, 2021
rsdmike
approved these changes
May 24, 2021
madhavilosetty-intel
force-pushed
the
mps-reverse-proxy
branch
from
33674d7
to
144e664
Compare
madhavilosetty-intel
force-pushed
the
mps-reverse-proxy
branch
from
144e664
to
903b199
Compare
BREAKING CHANGES: Metadata api route is removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: 'metadata' api route is removed.