Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROBOT should fail hard if CURIE prefix is unknown #880

Closed
2 tasks
matentzn opened this issue Jun 10, 2021 · 3 comments · Fixed by #882
Closed
2 tasks

ROBOT should fail hard if CURIE prefix is unknown #880

matentzn opened this issue Jun 10, 2021 · 3 comments · Fixed by #882
Assignees

Comments

@matentzn
Copy link
Contributor

matentzn commented Jun 10, 2021

  • Seems right now that robot templates does not fail hard when a prefix is unknown - instead an IRI is created in the form of a CURIE.

  • I was wishing to mention that as well in general - I did have some cases what playing with SPARQL for example that I accidentally introduced curies as entity ids, and it would be kind of great if I could know about this: Maybe I should make a ROBOT report check for that?

@beckyjackson
Copy link
Contributor

+1 to both of these. I'll take care of the template issue ASAP.

@beckyjackson beckyjackson self-assigned this Jun 10, 2021
@beckyjackson
Copy link
Contributor

I'm not sure what the best way to validate this is, though. Do we want to check it with regex? I've tried a couple of different solutions, but they cause ontology IRIs to become a problem because those often have "undefined" prefixes.

@matentzn
Copy link
Contributor Author

I think the check will probably only work for entities in the ontology (classes, properties etc) - or otherwise we have to explicitly encode exceptions.. There is no air-tight way to do this, but its important enough to merit at least some cursory kind of check - even if its a URL regex that ignores the ontology itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants