Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROBOT report has redundant \t (tab) in all all rows except header row. #737

Closed
matentzn opened this issue Sep 15, 2020 · 5 comments
Closed
Assignees

Comments

@matentzn
Copy link
Contributor

Version: ROBOT 1.7.0

robot report -I https://raw.githubusercontent.com/ontodev/robot/master/robot-core/src/test/resources/map_properties_up_test.owl --fail-on none --print 5 -o obo-report.tsv
cat obo-report.tsv | grep -E '.*(\t.*){4}' | wc -l # 61
cat obo-report.tsv | grep -E '.*(\t.*){5}' | wc -l # 60

On closer inspection, you can see that all lines apart from the header row have redundant \t characters in the end.

This confuses some tools (python libraries), while others, such as Excel or Numbers, appear unaffected.

image

@beckyjackson
Copy link
Contributor

I see this happening when I use v1.7.0 but it appears to be fixed in our unreleased version. Could you try with this JAR and let me know if it works for you?

1.7.0:
image

Unreleased:
image

We may need to address the fact that the ontology IRI is being turned into a CURIE, though...

@matentzn
Copy link
Contributor Author

Thanks a lot for looking into this! Hmm. Unfortunately I get this error, which seems unrelated:

robot report -i mondo.owl --fail-on none --print 5 -o test.tsv
2020-09-21 20:50:39,597 ERROR org.obolibrary.robot.ReportOperation - Could not complete query 'lowercase_definition' - report may be incomplete.
Cause:
iri cannot be null
report#MISSING ENTITY BINDING query 'lowercase_definition' must include an '?entity'
Use the -vvv option to show the stack trace.
Use the --help option to see usage information.

Never seen that before!

@beckyjackson
Copy link
Contributor

I think the key to that error is "iri cannot be null". Could you send me the full stack trace?

@matentzn
Copy link
Contributor Author

Thats all I think:

2020-09-21 21:04:25,235 ERROR org.obolibrary.robot.ReportOperation - Could not complete query 'lowercase_definition' - report may be incomplete.
Cause:
iri cannot be null
2020-09-21 21:04:25,236 DEBUG org.obolibrary.robot.ExceptionHelper - Missing exception ID: report#MISSING ENTITY BINDING query 'lowercase_definition' must include an '?entity'
report#MISSING ENTITY BINDING query 'lowercase_definition' must include an '?entity'
java.lang.Exception: report#MISSING ENTITY BINDING query 'lowercase_definition' must include an '?entity'
	at org.obolibrary.robot.ReportOperation.getReport(ReportOperation.java:287)
	at org.obolibrary.robot.ReportOperation.report(ReportOperation.java:233)
	at org.obolibrary.robot.ReportCommand.execute(ReportCommand.java:148)
	at org.obolibrary.robot.CommandManager.executeCommand(CommandManager.java:248)
	at org.obolibrary.robot.CommandManager.execute(CommandManager.java:192)
	at org.obolibrary.robot.CommandManager.main(CommandManager.java:139)
	at org.obolibrary.robot.CommandLineInterface.main(CommandLineInterface.java:60)

@matentzn
Copy link
Contributor Author

I am pretty sure this was fixed? @beckyjackson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants