Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow redirects for gzip input IRIs #537

Merged
merged 2 commits into from
Jul 17, 2019

Conversation

beckyjackson
Copy link
Contributor

Right now, we just pass the --input-iri URL to an input stream. If the URL redirects (e.g., for a purl), this does not follow the redirect and attempts to open a GZIP input stream from the non-redirected page.

This PR adds a method to follow redirects before attempting to open the input stream for an --input-iri ending in .gz. See #536.

@jamesaoverton
Copy link
Member

@rctauber We usually use OWLAPI to handle --input-iri, which follows redirects. For the special case of .gz IRI we have custom code that was not following redirects, and this PR fixes that. Correct?

@beckyjackson
Copy link
Contributor Author

That's exactly correct.

@jamesaoverton jamesaoverton merged commit 840bfd5 into ontodev:master Jul 17, 2019
@beckyjackson beckyjackson deleted the 536-gzip-fix branch July 17, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants