Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something is not working with the JSON parser #1009

Closed
matentzn opened this issue Jun 14, 2022 · 3 comments · Fixed by #1010
Closed

Something is not working with the JSON parser #1009

matentzn opened this issue Jun 14, 2022 · 3 comments · Fixed by #1010
Labels
Milestone

Comments

@matentzn
Copy link
Contributor

ROBOT 1.8.4:

robot convert -I http://purl.obolibrary.org/obo/pato.owl -f json -o pato.json

causes:

Exception in thread "main" java.lang.NoSuchMethodError: 'java.util.stream.Collector com.google.common.collect.ImmutableSet.toImmutableSet()'
	at org.geneontology.obographs.owlapi.FromOwl.generateGraph(FromOwl.java:236)
	at org.geneontology.obographs.owlapi.FromOwl.generateGraphDocument(FromOwl.java:63)
	at org.obolibrary.robot.IOHelper.saveOntologyFile(IOHelper.java:1720)
	at org.obolibrary.robot.IOHelper.saveOntology(IOHelper.java:846)
	at org.obolibrary.robot.CommandLineHelper.maybeSaveOutput(CommandLineHelper.java:667)
	at org.obolibrary.robot.ConvertCommand.execute(ConvertCommand.java:141)
	at org.obolibrary.robot.CommandManager.executeCommand(CommandManager.java:244)
	at org.obolibrary.robot.CommandManager.execute(CommandManager.java:188)
	at org.obolibrary.robot.CommandManager.main(CommandManager.java:135)
	at org.obolibrary.robot.CommandLineInterface.main(CommandLineInterface.java:60)
@matentzn matentzn added the bug label Jun 14, 2022
@jamesaoverton
Copy link
Member

Nico and I think this is a JAR packaging/shading problem with gson the combination of ROBOT and obographs.

Maybe related to our recent gson bump? #1003

It would be good to have a ROBOT integration test to cover this.

@jamesaoverton jamesaoverton added this to the 1.9.0 milestone Jun 14, 2022
@julesjacobsen
Copy link

julesjacobsen commented Jun 14, 2022

Since when has this been an issue? obographs-owlapi pulls in guava (the library where Google Immutable Collections lives) as a transitive dependency from obographs-core. Have you added the obographs-core dependency to robot-core/pom.xml too?

@jamesaoverton
Copy link
Member

As far as ROBOT is concerned, the problem was introduced in #934. When I build 999ded2, Nico's robot convert example succeeds, and when I build c195f5b it fails with the error above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants