Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix std::uncaught_exceptions #340

Merged
merged 1 commit into from
Feb 19, 2020
Merged

fix std::uncaught_exceptions #340

merged 1 commit into from
Feb 19, 2020

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Feb 18, 2020

Closes #333

@cyyever
Copy link
Contributor Author

cyyever commented Feb 18, 2020

May be possible to remove surrounding SUPPRESS_WARNING_WITH_PUSH

@onqtam
Copy link
Member

onqtam commented Feb 18, 2020

I think the #if __cplusplus >= 201703L conditional should be reversed to #if __cplusplus < 201703L - https://en.cppreference.com/w/cpp/error/uncaught_exception

@cyyever
Copy link
Contributor Author

cyyever commented Feb 18, 2020

I think the #if __cplusplus >= 201703L conditional should be reversed to #if __cplusplus < 201703L - https://en.cppreference.com/w/cpp/error/uncaught_exception

I try to use __cplusplus and Feature-Test Macro together to avoid error-prone compiler version checks.

@cyyever
Copy link
Contributor Author

cyyever commented Feb 18, 2020

I think the #if __cplusplus >= 201703L conditional should be reversed to #if __cplusplus < 201703L - https://en.cppreference.com/w/cpp/error/uncaught_exception

Sorry, I made a stupid error. I should exchange the if statements.

@cyyever
Copy link
Contributor Author

cyyever commented Feb 19, 2020 •
edited
Loading

@onqtam One test case failed, but it seems unrelated to the PR. Could you accept it?

@onqtam onqtam changed the base branch from master to dev February 19, 2020 13:27
@onqtam onqtam merged commit c995c03 into doctest:dev Feb 19, 2020
@onqtam
Copy link
Member

onqtam commented Feb 19, 2020

I merged it into the dev branch - will soon release an official version in master. Thanks for this and sorry for the delay - been busy lately!

@onqtam onqtam mentioned this pull request Feb 19, 2020
Closed
onqtam pushed a commit that referenced this pull request Feb 24, 2020
@cyyever @onqtam
fix std::uncaught_exceptions (#340) - closes #333
f7bcaaa
@cyyever cyyever deleted the fix_uncaught_exceptions branch March 2, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C++20 removed std::uncaught_exception
2 participants
@cyyever @onqtam