-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : including windows.h header cause error #258
Conversation
Thanks very much for this fix, as we had the exact same problem adding doctest support to ApprovalTest.cpp. The fix almost works - it just has a stray We suggest just changing |
https: //github.com/doctest/doctest/pull/258 Co-Authored-By: Llewellyn Falco <isidore@users.noreply.github.com>
Thank you for fixing it!!! |
@rinechran You're welcome, but we only fixed it in our copy of the doctest single header... It remains to be fixed in the master repo, so please could you re-open this issue? |
@claremacrae sorry I first tried to pull request and I accidentally closed the issue. |
thanks! |
Description
includeing windows.h header caause error
because includeing std:: max will call max in windows.h.
GitHub Issues
Noting