Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #239 - use long macro name #240

Merged
merged 1 commit into from
May 28, 2019
Merged

fix #239 - use long macro name #240

merged 1 commit into from
May 28, 2019

Conversation

m-bd
Copy link
Contributor

@m-bd m-bd commented May 23, 2019

Description

Use long macro name to define DOCTEST_GIVEN.

I should add a test this weekend to check that short names are not used in definitions.

GitHub Issues

fix #239

@onqtam
Copy link
Member

onqtam commented May 24, 2019

I'm not sure how to add tests to check if something doesn't compile - there isn't such infrastructure in the repository yet. I would merge it as it is for now.

@onqtam onqtam marked this pull request as ready for review May 28, 2019 09:36
@onqtam onqtam merged commit 86fccdf into doctest:dev May 28, 2019
@onqtam
Copy link
Member

onqtam commented May 28, 2019

seems I can just merge it directly (make the PR from a draft to a ready one). Thanks :)

@m-bd
Copy link
Contributor Author

m-bd commented May 28, 2019 via email

onqtam pushed a commit that referenced this pull request Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants