Fixed build error under Android NDK #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise clang will complain about
```
cannot initialize a member subobject of type 'int' with an rvalue of type 'nullptr_t'
struct sigaction sa = {nullptr};
^~~~~~~
```
|
Thanks! I'll also commit warning suppressions around that piece of code because of not using nullptr with other compilers |
theodelrieu
reviewed
Nov 27, 2018
| @@ -1430,7 +1430,7 @@ namespace { | |||
| sigStack.ss_size = sizeof(altStackMem); | |||
| sigStack.ss_flags = 0; | |||
| sigaltstack(&sigStack, &oldSigStack); | |||
| struct sigaction sa = {nullptr}; | |||
| struct sigaction sa = {0}; | |||
There was a problem hiding this comment.
Shouldn't it be struct sigaction sa{}?
I'm not sure if this initializes all the struct members, whereas value-initialization will.
onqtam
added a commit
that referenced
this pull request
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allow doctest to build cleanly with the Android NDK, using the clang compiler targeting arm64
Without it, clang will complain about