Fix macros WIN32_LEAN_AND_MEAN typo #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix macros `WIN32_LEAN_AND_MEAN` typo
|
look at what I found :D There are a few other mentions of Thanks for this - merging! |
|
Yeah, usually it's not clear to see when the macro works properly. Actually, I found it when I added a header "Winsock2.h", which conflicts with "Winsock.h". Last one should not be included in "Windows.h" by WIN32_LEAN_AND_MEAN macro. |
onqtam
pushed a commit
that referenced
this pull request
Feb 6, 2018
Fix macros `WIN32_LEAN_AND_MEAN` typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix macros
WIN32_LEAN_AND_MEANtypoDescription
This pull request changes a define of macros WIN32_MEAN_AND_LEAN to WIN32_LEAN_AND_MEAN. This should increase compilation speed.
Also, it removes warnings when a header 'Winsock2.h' be included.
GitHub Issues