Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal stack size too small on Linux #129

Closed
jwalt opened this issue Apr 24, 2018 · 1 comment
Closed

Signal stack size too small on Linux #129

jwalt opened this issue Apr 24, 2018 · 1 comment

Comments

@jwalt
Copy link

jwalt commented Apr 24, 2018

On my Linux box, this line...

https://github.com/onqtam/doctest/blob/fec6e4a5f570dfa8ba4b715bc8fa4f51a8b70557/doctest/doctest.h#L4485

... expands to 8kiB of signal stack. This seems to be too small, as I sometimes get segmentation faults in logTestStart (or rather, snprintf) when handling signals. The windows branch of this code uses 32kiB, so I suggest to do the same for POSIX boxes.

Also, I suggest replacing later ocurrences of SIGSTKSZ with sizeof(altStackMem) for increased maintainability.

@onqtam
Copy link
Member

onqtam commented Apr 30, 2018

sounds reasonable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants