Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Intel Compiler #128

Closed
smcallis opened this issue Apr 19, 2018 · 5 comments
Closed

Support Intel Compiler #128

smcallis opened this issue Apr 19, 2018 · 5 comments

Comments

@smcallis
Copy link
Contributor

It'd be great if doctest could compile under Intel >= 13. It has most of C++11, but a few things missing, notable thread_local. I'd be happy to submit a pull request if someone could give me a rundown on what needs to be detected and configured.

@onqtam
Copy link
Member

onqtam commented Apr 19, 2018

Well have you tried it with the Intel compiler? doctest can compile in C++98 without any trouble and currently doesn't use thread_local anything. It uses some C++11 features only if it detects them as available. I'd be happy to address any compiler errors once reported, but I assume it should work out of the box. I might also give the compiler a go in a week or two on my machine... But I just haven't felt the need for it yet.

EDIT:

I just went on their download page aaaaaaaand............... for open-source contributors it's available only for linux? seriously? but for teachers and students - windows as well? ........... apparently I don't even qualify.
https://software.intel.com/en-us/parallel-studio-xe/choose-download#open-source-contributors

@smcallis
Copy link
Contributor Author

I have tried it on Intel 13, and it was unhappy, though I can't tell you exactly why. I'll try to get it a gist put up shortly. I think the problem is I compile with --std=c++11 and Intel 13 reports itself as perhaps more compliant than it actually is.

@smcallis
Copy link
Contributor Author

So testing it out today, a fair bit of the problem was on my end, I saw lots of errors and assumed it was doctest (I thought it required C++11). Now that I know that, the only thing I had to do to get it working nicely with the Intel compiler was to disable the GCC warning pragmas if Intel is detected, and pass in -wd2196 to disablethe annoying "routing is both inline and noinline" nonsense it prints out.

@onqtam
Copy link
Member

onqtam commented Apr 30, 2018

could you produce a PR for the Intel support?

@smcallis
Copy link
Contributor Author

Yup! I'm waiting for my revisions to get transferred somewhere I can access them, then I'll submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants