Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any upgrades on tf2onnx #2287

Closed
hanzigs opened this issue Jan 4, 2024 · 3 comments · Fixed by #2288
Closed

Is there any upgrades on tf2onnx #2287

hanzigs opened this issue Jan 4, 2024 · 3 comments · Fixed by #2288
Labels
bug An unexpected problem or unintended behavior question An issue, pull request, or discussion needs more information

Comments

@hanzigs
Copy link

hanzigs commented Jan 4, 2024

tf2onnx 1.16.0 requires protobuf~=3.20.2
but
tensorflow-intel 2.15.0 requires protobuf!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5,<5.0.0dev,>=3.20.3, but you have protobuf 3.20.2 which is incompatible.
Using python 3.11.7
Thanks in advance

@hanzigs hanzigs added the question An issue, pull request, or discussion needs more information label Jan 4, 2024
@fatcat-z fatcat-z added the bug An unexpected problem or unintended behavior label Jan 5, 2024
@fatcat-z
Copy link
Collaborator

fatcat-z commented Jan 5, 2024

Yes, it should be fixed. A workaround is: after install tf2onnx 1.16, please feel free to upgrade protobuf to 3.20.3 and tf2onnx supports it as well.

@hanzigs
Copy link
Author

hanzigs commented Jan 5, 2024

and support for protobuf 4.x as well please. because some libraries using protobuf 4.24.3. many Thanks.

@fatcat-z
Copy link
Collaborator

fatcat-z commented Jan 5, 2024

and support for protobuf 4.x as well please. because some libraries using protobuf 4.24.3. many Thanks.

Actually, for most of case, tf 2.x and protobuf 4.x works well. But tf2onnx still needs to support tf 1.15. version which is used by a lot of developers. So the official version of protobuf has to be limited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior question An issue, pull request, or discussion needs more information
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants