Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Custom Color Picker #89

Closed
drfarrell opened this issue Jul 30, 2024 · 9 comments · Fixed by #588 or #609
Closed

[FEAT] Custom Color Picker #89

drfarrell opened this issue Jul 30, 2024 · 9 comments · Fixed by #588 or #609
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Great issues to tackle during hacktoberfest

Comments

@drfarrell
Copy link
Collaborator

We need a custom Color Picker + Variable selector module for Onlook.

Requirements

  • It should use Onlook's custom variables and brand colors
  • It should take as little space as possible on the screen
  • It should have room for presets to be chosen.

image

Some inspiration for what color pickers could look like:
https://www.tldraw.com/r/IjnaUuT7EdRlaflRWj4Fu?v=-2045,-1060,7478,4112&p=page

Open for Design suggestions and contributions!

@drfarrell drfarrell added enhancement New feature or request good first issue Good for newcomers labels Jul 30, 2024
@Koppeks
Copy link

Koppeks commented Jul 30, 2024

Hi I would like to help with this, do you need just the design or do you also want a pull request with the code?

@drfarrell
Copy link
Collaborator Author

Open to either! Both would be helpful. We already have a base color picker, we just need to wrap it for pre-set variables and such.

Screenshot 2024-07-30 at 7 45 46 PM

What would you be excited to work on? I can get you a design if you'd like to help implement it.

This is also similar to this issue #49 if you want to take a look through it and see if there's something there you'd like to work on.

@Koppeks
Copy link

Koppeks commented Jul 31, 2024

Does the repo work in Windows? I saw that the only download method was IOS.
If only works on iOS I would be glad to only contribute with design 🦩

@Kitenite
Copy link
Contributor

@Koppeks it should work on Windows using the local instructions. We just haven't shipped a Windows executable for sake of focus.

Please let me know if you could not run it.

@ErrolFernandes
Copy link

Frame 3

@drfarrell
Copy link
Collaborator Author

Frame 3

Thanks for putting this together @ErrolFernandes!

If you want to keep jamming on it, here are some ideas of other things we need.

  • We need to eventually support Gradients like Framer and Figma. Would be great to add those in somewhere.
  • I like how both Figma and Framer let you look over the names of the colors you're looking to choose – it'd be great to see what a list of colors looks like
  • Also Figma and Framer have the ability to search for specific colors. Wonder where the best place to put a search bar would be. We use Radix 15px icons if you want to use them as a reference.
  • We'll also need to support HSL, HEX, RGB, etc. colors, so we need a place to swap those modes out.

@drfarrell
Copy link
Collaborator Author

drfarrell commented Sep 13, 2024

image

A light mockup of what the picker can look like (still will add in gradient and variables and such)

The pin icon should be a color picker icon but is a placeholder because Radix doesn't have an eyedropper.

#337 is a request for this (Closed)

@drfarrell drfarrell added the hacktoberfest Great issues to tackle during hacktoberfest label Oct 2, 2024
@drfarrell
Copy link
Collaborator Author

Here's what I think the v1 design should look like, and there's an even simpler version on the right.
image

This is an example showing how the headers should "stick" to the top as the user scrolls through the selection. This will only apply when we have more than one fill type (color, gradient, image, etc.)
Export-1729268956709

@hitaspdotnet
Copy link
Contributor

I'm on it, assign me please if possible.

WIP screen:
image

hitaspdotnet added a commit to hitaspdotnet/onlook that referenced this issue Oct 19, 2024
This was linked to pull requests Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Great issues to tackle during hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants