Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Right-Click Menu v0 #73

Closed
drfarrell opened this issue Jul 18, 2024 · 6 comments · Fixed by #206
Closed

[FEAT] Right-Click Menu v0 #73

drfarrell opened this issue Jul 18, 2024 · 6 comments · Fixed by #206
Assignees
Labels
blocked Not actionable at the moment enhancement New feature or request

Comments

@drfarrell
Copy link
Collaborator

So much functionality in an editor can be enabled with a right-click menu. It helps abstract away secondary actions.

  • The right-click menu will be used for both elements on the canvas and in the toolbars of the browser.
  • Right-click actions should also show Hotkeys. If Hotkeys aren't in-production yet, placeholder hotkey labels can be commented-out of the components
  • The icons are Radix icons.
  • Please use the custom tailwind styles when implementing these so we keep everything on brand 😄

image
image

@drfarrell drfarrell added enhancement New feature or request good first issue Good for newcomers labels Jul 18, 2024
@Kitenite
Copy link
Contributor

I like it! Some good options to stub out:
Screenshot 2024-07-18 at 9 36 53 AM

@Kitenite Kitenite added the in progress Someone is actively working on this label Aug 2, 2024
@Kitenite
Copy link
Contributor

Kitenite commented Aug 5, 2024

@nicklammo since you're already working on this, please comment on this issue then I can add you as an assignee

@nicklammo
Copy link
Contributor

@Kitenite I gave it a good try anyway

@Kitenite
Copy link
Contributor

Kitenite commented Aug 6, 2024

@nicklammo delivered a fork, will work on adding it to a PR.

@Kitenite Kitenite removed the in progress Someone is actively working on this label Aug 6, 2024
@drfarrell drfarrell moved this to Todo in Onlook Studio v0 Aug 18, 2024
@drfarrell drfarrell changed the title [FEAT] Right-Click Menu v1.0 [FEAT] Right-Click Menu v0 Aug 18, 2024
@drfarrell
Copy link
Collaborator Author

drfarrell commented Aug 18, 2024

Added in some standard menus for right-clicking on a layer or a component on the canvas. New hotkeys for each feature are bolded and italicized.

V0

  • Copy: ⌘C
  • Paste here: ⌘V
  • Cut: ⌘X
  • Duplicate: ⌘D
  • Delete: ⌫
  • Select all: ⌘A
  • Bring to front: ⌘] (in the stack of layers relative to the parent)
  • Bring forward: ]
  • Send to back: ⌘[
  • Send backward: [
  • Add auto layout: ⇧A
  • Show/Hide UI: ⌘.

V1

  • Copy: ⌘C
  • Copy/Paste as:
  • - Paste here: ⌘V
  • - Paste styles: ⌥⌘V
  • Cut: ⌘X
  • Duplicate: ⌘D
  • Delete: ⌫
  • Bring to front: ⌘]
  • Bring forward: ]
  • Send to back: ⌘[
  • Send backward: [
  • Create Div around selection: ⌘G
  • Undo Div around selection: ⇧⌘G
  • Add auto layout: ⇧A
  • Show/Hide UI: ⌘.

V2

  • Copy: ⌘C
  • Copy/Paste as:
  • - Copy as SVG: ⇧⌘C
  • - Copy link to selection: ⌥⌘L
  • - Paste here: ⌘V
  • - Paste styles: ⌥⌘V
  • Cut: ⌘X
  • Duplicate: ⌘D
  • Delete: ⌫
  • Bring to front: ⌘]
  • Bring forward: ]
  • Send to back: ⌘[
  • Send backward: [
  • Create Div around selection: ⌘G
  • Undo Div around selection: ⇧⌘G
  • Rename: ⌘R
  • Add auto layout: ⇧A
  • Create component: ⌥⌘K
  • Show/Hide UI: ⌘.
  • Lock/Unlock: ⌥⌘L

@drfarrell drfarrell added this to the Complete Onlook Studio V0 milestone Aug 19, 2024
@Kitenite Kitenite linked a pull request Aug 23, 2024 that will close this issue
6 tasks
@Kitenite Kitenite removed their assignment Aug 23, 2024
@Kitenite Kitenite added blocked Not actionable at the moment and removed good first issue Good for newcomers labels Aug 23, 2024
@Kitenite
Copy link
Contributor

Kitenite commented Aug 23, 2024

Partially implemented in #206
We don't have the rest of the defined functionalities yet, marking as blocked until further notice.

@Kitenite Kitenite moved this from Todo to Blocked in Onlook Studio v0 Aug 27, 2024
@Kitenite Kitenite closed this as completed by moving to Done in Onlook Studio v0 Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Not actionable at the moment enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants