Empty Workspace fixes (#2353)

* Remove test file commands when not in a workspace. * Also fix Ctrl-P menu when no workspace is open. * Fix lint.
onivim · Jun 25, 2018 · d1a818e · d1a818e
1 parent 7b15dce
commit d1a818e
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 1 deletion.
diff --git a/browser/src/Services/QuickOpen/QuickOpen.ts b/browser/src/Services/QuickOpen/QuickOpen.ts
@@ -290,9 +290,13 @@ export class QuickOpen {
             const file = path.basename(f)
             const folder = path.dirname(f)
             const pinned = this._seenItems.indexOf(f) >= 0
+            const icon =
+                QuickOpenItem.convertIconToType(qitem.icon) !== QuickOpenType.file
+                    ? qitem.icon
+                    : (getFileIcon(file) as any)
 
             return {
-                icon: getFileIcon(file) as any,
+                icon,
                 label: file,
                 detail: folder,
                 pinned,

diff --git a/browser/src/Services/QuickOpen/QuickOpenItem.ts b/browser/src/Services/QuickOpen/QuickOpenItem.ts
@@ -8,6 +8,7 @@ export enum QuickOpenType {
     folder,
     folderHelp,
     bufferLine,
+    unknown,
 }
 
 // Wrapper around quick open items, this not only allows us to show multiple icons
@@ -33,6 +34,25 @@ export class QuickOpenItem {
         }
     }
 
+    public static convertIconToType(icon: string): QuickOpenType {
+        switch (icon) {
+            case "star-o":
+                return QuickOpenType.bookmark
+            case "info":
+                return QuickOpenType.bookmarkHelp
+            case "file-text-o":
+                return QuickOpenType.file
+            case "folder-o":
+                return QuickOpenType.folder
+            case "folder-open-o":
+                return QuickOpenType.folderHelp
+            case "angle-right":
+                return QuickOpenType.bufferLine
+            default:
+                return QuickOpenType.unknown
+        }
+    }
+
     // Each has an item, and an icon
     private _item: string
     private _icon: string

diff --git a/browser/src/Services/Workspace/WorkspaceCommands.ts b/browser/src/Services/Workspace/WorkspaceCommands.ts
@@ -69,6 +69,11 @@ export const activateCommands = (
             return null
         }
 
+        // If we have no active workspace, we don't know where test files live.
+        if (!workspace.activeWorkspace) {
+            return null
+        }
+
         const currentEditor = editorManager.activeEditor
 
         if (!currentEditor || !currentEditor.activeBuffer) {