Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add support for start and end heights returned by GetEventsForHeightRange #1581

Open
justinbarry opened this issue Mar 9, 2023 · 4 comments
Assignees

Comments

@justinbarry
Copy link
Contributor

Following this issue.

After that, we need to decide how to support it going forward. Two options:

  1. Surface the "end_height" to the dapp, allowing the dapp to decide on when to poll for the missing blocks.
  2. FCL internally will keep polling until all the blocks are requested.
@spacepluk
Copy link

FWIW in our dapp if we don't get all the events for a range we're going to request the whole thing again.

@bluesign
Copy link

Surface the "end_height" to the dapp, allowing the dapp to decide on when to poll for the missing blocks.
FCL internally will keep polling until all the blocks are requested.

why not both?

@spacepluk
Copy link

I think 1 is a prerequisite for 2.

@justinbarry
Copy link
Contributor Author

@spacepluk Depends on if we decide to build the "retry" login into FCL proper or not. Given that we prefer keeping FCL Core simple, we will probably choose option 1 with some nifty JS Doc examples showcasing retry logic. Retrying the whole range is a very viable option.

There is a conversation happening here around streaming events which will remove the need for polling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants