Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove testing harness #126

Open
justinbarry opened this issue Jul 12, 2022 · 4 comments
Open

Remove testing harness #126

justinbarry opened this issue Jul 12, 2022 · 4 comments
Assignees
@justinbarry

Comments

@justinbarry
Copy link
Contributor

Replace bundled dev wallet with https://github.com/onflow/fcl-next-harness.
@gregsantos
Copy link
Contributor

Should wait until FCLCrypto contract is deployed on emulator by default or may lead to issues attempting to verify account-proof on authn

@chasefleming
Copy link
Member

@justinbarry @gregsantos Heads up it looks like this may break the cypress tests. Looks like it uses harness as its baseUrl.

@justinbarry
Copy link
Contributor Author

My thinking was that we could import the other harness as a dependency and host it here.

@gregsantos
Copy link
Contributor

That would work, but if there's a test for login/authn will fail unless FCLCrypto contract is deployed to emulator

@sideninja sideninja moved this to 🔖 Ready for Pickup in 🌊 Flow 4D Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinbarry justinbarry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justinbarry @gregsantos @chasefleming