Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor domains to prevent import cycles and simplify maintenance #3672

Closed
fxamacker opened this issue Nov 8, 2024 · 0 comments · Fixed by #3673
Closed

Refactor domains to prevent import cycles and simplify maintenance #3672

fxamacker opened this issue Nov 8, 2024 · 0 comments · Fixed by #3673
Assignees

Comments

@fxamacker
Copy link
Member

Issue to be solved

Currently, different domains are defined in these packages:

  • common
  • runtime
  • stdlib

This can cause import cycles in future PRs that use domains across these packages. Also, having domains defined in different packages creates risk of overlooking domains.

Suggested Solution

We can define all domains in one place to help prevent import cycles and make it easier to maintain domains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant