Skip to content

Commit 4443262

Browse files
committed
update access modifiers to Cadence 1.0
1 parent 7d1f947 commit 4443262

File tree

2 files changed

+9
-12
lines changed

2 files changed

+9
-12
lines changed

languageserver/server/document_test.go

+7-7
Original file line numberDiff line numberDiff line change
@@ -41,20 +41,20 @@ func TestDocument_HasAnyPrecedingStringsAtPosition(t *testing.T) {
4141

4242
t.Parallel()
4343

44-
doc := Document{Text: " pub \t \n f"}
44+
doc := Document{Text: " access(all) \t \n f"}
4545

46-
assert.True(t, doc.HasAnyPrecedingStringsAtPosition([]string{"pub"}, 2, 1))
47-
assert.True(t, doc.HasAnyPrecedingStringsAtPosition([]string{"pub"}, 2, 2))
48-
assert.True(t, doc.HasAnyPrecedingStringsAtPosition([]string{"pub"}, 2, 3))
49-
assert.True(t, doc.HasAnyPrecedingStringsAtPosition([]string{"access(self)", "pub"}, 2, 2))
50-
assert.True(t, doc.HasAnyPrecedingStringsAtPosition([]string{"access(self)", "pub"}, 1, 6))
46+
assert.True(t, doc.HasAnyPrecedingStringsAtPosition([]string{"access(all)"}, 2, 1))
47+
assert.True(t, doc.HasAnyPrecedingStringsAtPosition([]string{"access(all)"}, 2, 2))
48+
assert.True(t, doc.HasAnyPrecedingStringsAtPosition([]string{"access(all)"}, 2, 3))
49+
assert.True(t, doc.HasAnyPrecedingStringsAtPosition([]string{"access(self)", "access(all)"}, 2, 2))
50+
assert.True(t, doc.HasAnyPrecedingStringsAtPosition([]string{"access(self)", "access(all)"}, 1, 13))
5151
})
5252

5353
t.Run("invalid", func(t *testing.T) {
5454

5555
t.Parallel()
5656

57-
doc := Document{Text: " pub \t \n f"}
57+
doc := Document{Text: " access(all) \t \n f"}
5858

5959
assert.False(t, doc.HasAnyPrecedingStringsAtPosition([]string{"access(self)"}, 2, 2))
6060
})

languageserver/server/server.go

+2-5
Original file line numberDiff line numberDiff line change
@@ -1129,12 +1129,9 @@ var expressionCompletionItems = []*protocol.CompletionItem{
11291129
},
11301130
}
11311131

1132-
var allAccessOptions = []string{"pub", "priv", "pub(set)", "access(contract)", "access(account)", "access(self)"}
1132+
var allAccessOptions = []string{"access(all)", "access(contract)", "access(account)", "access(self)"}
11331133
var allAccessOptionsCommaSeparated = strings.Join(allAccessOptions, ",")
11341134

1135-
var readAccessOptions = []string{"pub", "priv", "access(contract)", "access(account)", "access(self)"}
1136-
var readAccessOptionsCommaSeparated = strings.Join(readAccessOptions, ",")
1137-
11381135
// NOTE: if the document doesn't specify an access modifier yet,
11391136
// the completion item's InsertText will get prefixed with a placeholder
11401137
// for the access modifier.
@@ -1287,7 +1284,7 @@ func (s *Server) Completion(
12871284
if requiresAccessModifierPlaceholder {
12881285
item = withCompletionItemInsertText(
12891286
item,
1290-
fmt.Sprintf("${1|%s|} %s", readAccessOptionsCommaSeparated, item.InsertText),
1287+
fmt.Sprintf("${1|%s|} %s", allAccessOptionsCommaSeparated, item.InsertText),
12911288
)
12921289
}
12931290
items = append(items, item)

0 commit comments

Comments
 (0)