Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address validation is disable still api calls #288

Open
Nehace40 opened this issue Mar 7, 2019 · 3 comments
Open

Address validation is disable still api calls #288

Nehace40 opened this issue Mar 7, 2019 · 3 comments

Comments

@Nehace40
Copy link

Nehace40 commented Mar 7, 2019

We are using avatax module.

Address Validation setting is disabled. when we check in avatax account it is showing there Address validation api is called several time.

Why it is calling Address validation API?

@Nehace40
Copy link
Author

Nehace40 commented Mar 8, 2019

Any Updates?

1 similar comment
@Nehace40
Copy link
Author

Any Updates?

@kmdsax
Copy link

kmdsax commented Mar 11, 2019

Battling this same issue myself! I believe the bug lies in Model\Action\Validator.php , line 79, the last condition in the if statement should be flipped:

    if (!$isAddressValidationOn && !$isAddressNormalizationOn && !$isAddressActionable) {
        return true;
    }

should be changed to:

    if (!$isAddressValidationOn && !$isAddressNormalizationOn && $isAddressActionable) {
        return true;
    }

In my testing this does seem to solve the issue while not breaking anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants