Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in DSA_SHA1 constant's value? #238

Closed
chipx86 opened this issue Sep 21, 2018 · 2 comments
Closed

Typo in DSA_SHA1 constant's value? #238

chipx86 opened this issue Sep 21, 2018 · 2 comments

Comments

@chipx86
Copy link

chipx86 commented Sep 21, 2018

I'm just getting familiar with this package, but while browsing through the constants, I noticed this inconsistency:

https://github.com/onelogin/python-saml/blob/3814b0fe98d6ab78cf92b39c15e1785b1cab22bb/src/onelogin/saml2/constants.py#L106

Note the / in the value http://www.w3.org/2000/09/xmld/sig#dsa-sha1, which differs from every spec I can find, including information on the package's README. I imagine this should be http://www.w3.org/2000/09/xmldsig#dsa-sha1.

@pitbulk
Copy link
Contributor

pitbulk commented Sep 21, 2018

You are right, do you have a PR?

@chipx86
Copy link
Author

chipx86 commented Sep 21, 2018

I don't. I'm happy to put one together but I'm just about to take off for a vacation and wanted to check on this before I completely forget in a week :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants