From dd6b148b4c620c62cd5febe4e5d8ce4118995422 Mon Sep 17 00:00:00 2001 From: hakimuddinhh Date: Sun, 13 Oct 2024 13:05:03 +0530 Subject: [PATCH] Partial changes for issue #656 - Removed focusableWhenDisabled from Menu trigger - Passed down disabled prop to the component renderer to enable the disabled state to the DOM element --- docs/data/api/menu-trigger.json | 1 - .../api-docs/menu-trigger/menu-trigger.json | 3 --- packages/mui-base/src/Checkbox/Root/CheckboxRoot.tsx | 1 + packages/mui-base/src/Menu/Trigger/MenuTrigger.tsx | 10 ---------- packages/mui-base/src/Menu/Trigger/useMenuTrigger.ts | 1 - packages/mui-base/src/Switch/Root/SwitchRoot.tsx | 2 +- 6 files changed, 2 insertions(+), 16 deletions(-) diff --git a/docs/data/api/menu-trigger.json b/docs/data/api/menu-trigger.json index 05e73a2a8..5605811cd 100644 --- a/docs/data/api/menu-trigger.json +++ b/docs/data/api/menu-trigger.json @@ -2,7 +2,6 @@ "props": { "className": { "type": { "name": "union", "description": "func
| string" } }, "disabled": { "type": { "name": "bool" }, "default": "false" }, - "focusableWhenDisabled": { "type": { "name": "bool" }, "default": "false" }, "label": { "type": { "name": "string" } }, "render": { "type": { "name": "union", "description": "element
| func" } } }, diff --git a/docs/data/translations/api-docs/menu-trigger/menu-trigger.json b/docs/data/translations/api-docs/menu-trigger/menu-trigger.json index 814aa3e49..226048246 100644 --- a/docs/data/translations/api-docs/menu-trigger/menu-trigger.json +++ b/docs/data/translations/api-docs/menu-trigger/menu-trigger.json @@ -5,9 +5,6 @@ "description": "Class names applied to the element or a function that returns them based on the component's state." }, "disabled": { "description": "If true, the component is disabled." }, - "focusableWhenDisabled": { - "description": "If true, allows a disabled button to receive focus." - }, "label": { "description": "Label of the button" }, "render": { "description": "A function to customize rendering of the component." } }, diff --git a/packages/mui-base/src/Checkbox/Root/CheckboxRoot.tsx b/packages/mui-base/src/Checkbox/Root/CheckboxRoot.tsx index 4e3dcf87b..15bbbfc0f 100644 --- a/packages/mui-base/src/Checkbox/Root/CheckboxRoot.tsx +++ b/packages/mui-base/src/Checkbox/Root/CheckboxRoot.tsx @@ -98,6 +98,7 @@ const CheckboxRoot = React.forwardRef(function CheckboxRoot( extraProps: { ...otherProps, ...otherGroupProps, + disabled }, }); diff --git a/packages/mui-base/src/Menu/Trigger/MenuTrigger.tsx b/packages/mui-base/src/Menu/Trigger/MenuTrigger.tsx index 4e977f9f8..b33b2edad 100644 --- a/packages/mui-base/src/Menu/Trigger/MenuTrigger.tsx +++ b/packages/mui-base/src/Menu/Trigger/MenuTrigger.tsx @@ -69,11 +69,6 @@ namespace MenuTrigger { * @default false */ disabled?: boolean; - /** - * If `true`, allows a disabled button to receive focus. - * @default false - */ - focusableWhenDisabled?: boolean; /** * Label of the button */ @@ -103,11 +98,6 @@ MenuTrigger.propTypes /* remove-proptypes */ = { * @default false */ disabled: PropTypes.bool, - /** - * If `true`, allows a disabled button to receive focus. - * @default false - */ - focusableWhenDisabled: PropTypes.bool, /** * Label of the button */ diff --git a/packages/mui-base/src/Menu/Trigger/useMenuTrigger.ts b/packages/mui-base/src/Menu/Trigger/useMenuTrigger.ts index 4a69d607f..e1da262aa 100644 --- a/packages/mui-base/src/Menu/Trigger/useMenuTrigger.ts +++ b/packages/mui-base/src/Menu/Trigger/useMenuTrigger.ts @@ -23,7 +23,6 @@ export function useMenuTrigger(parameters: useMenuTrigger.Parameters): useMenuTr const { getButtonProps, buttonRef } = useButton({ disabled, - focusableWhenDisabled: false, buttonRef: mergedRef, }); diff --git a/packages/mui-base/src/Switch/Root/SwitchRoot.tsx b/packages/mui-base/src/Switch/Root/SwitchRoot.tsx index 40831d0b5..3e15e7d1f 100644 --- a/packages/mui-base/src/Switch/Root/SwitchRoot.tsx +++ b/packages/mui-base/src/Switch/Root/SwitchRoot.tsx @@ -59,7 +59,7 @@ const SwitchRoot = React.forwardRef(function SwitchRoot( className, propGetter: getButtonProps, ownerState, - extraProps: other, + extraProps: {...other, disabled}, customStyleHookMapping: styleHookMapping, ref: forwardedRef, });