Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix message when there are no celebrations #21

Merged
merged 6 commits into from
Apr 14, 2023
Merged

Fix message when there are no celebrations #21

merged 6 commits into from
Apr 14, 2023

Conversation

inigomarquinez
Copy link
Contributor

Main changes

  • 🐛 amend published message when there are no celebrations

Other changes

  • 🔄 split publishers in different files for better readability
  • 🔄 split slack message builder for celebrations for better readability
  • 📝 improve README

Screenshots

Captura de pantalla 2023-03-17 a las 9 44 43

@inigomarquinez inigomarquinez added bug Something isn't working documentation Improvements or additions to documentation labels Mar 17, 2023
@inigomarquinez inigomarquinez self-assigned this Mar 17, 2023
@inigomarquinez
Copy link
Contributor Author

@all-contributors please add @inigomarquinez for bugs, code, doc, infra, maintenance, review, test

@allcontributors allcontributors bot mentioned this pull request Mar 17, 2023
Merged
@allcontributors
Copy link
Contributor

@inigomarquinez

I've put up a pull request to add @inigomarquinez! 🎉

@inigomarquinez
Copy link
Contributor Author

@all-contributors please add @totegsito for bugs, code, doc, maintenance, review

@allcontributors allcontributors bot mentioned this pull request Mar 17, 2023
Closed
@allcontributors
Copy link
Contributor

@inigomarquinez

I've put up a pull request to add @totegsito! 🎉

@inigomarquinez
Copy link
Contributor Author

@all-contributors please add @Betisman for review

@allcontributors allcontributors bot mentioned this pull request Mar 17, 2023
Closed
@allcontributors
Copy link
Contributor

@inigomarquinez

I've put up a pull request to add @Betisman! 🎉

@inigomarquinez
Copy link
Contributor Author

@all-contributors please add @w3dani for infra, review

@allcontributors allcontributors bot mentioned this pull request Mar 17, 2023
Closed
@allcontributors
Copy link
Contributor

@inigomarquinez

I've put up a pull request to add @w3dani! 🎉

@inigomarquinez
Copy link
Contributor Author

@all-contributors please add @totegsito for bugs, code, doc, maintenance, review

@allcontributors
Copy link
Contributor

@inigomarquinez

@totegsito already contributed before to bug, code, doc, maintenance, review

@inigomarquinez
Copy link
Contributor Author

@all-contributors please add @totegsito for bugs, code, doc, maintenance, review

@allcontributors allcontributors bot mentioned this pull request Mar 17, 2023
Merged
@allcontributors
Copy link
Contributor

@inigomarquinez

I've put up a pull request to add @totegsito! 🎉

@inigomarquinez
Copy link
Contributor Author

@all-contributors please add @Betisman for review

@allcontributors allcontributors bot mentioned this pull request Mar 17, 2023
Merged
@allcontributors
Copy link
Contributor

@inigomarquinez

I've put up a pull request to add @Betisman! 🎉

@inigomarquinez
Copy link
Contributor Author

@all-contributors please add @w3dani for infra, review

@allcontributors allcontributors bot mentioned this pull request Mar 17, 2023
Merged
@allcontributors
Copy link
Contributor

@inigomarquinez

I've put up a pull request to add @w3dani! 🎉

Betisman
Betisman approved these changes Mar 17, 2023
View reviewed changes
Copy link

@Betisman Betisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job.

Next time we could split code changes and doc changes into different commits.

totegsito
totegsito approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@totegsito totegsito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🫠

totegsito
totegsito reviewed Mar 30, 2023
View reviewed changes
@inigomarquinez inigomarquinez mentioned this pull request Apr 14, 2023
Open
@inigomarquinez inigomarquinez merged commit b77e7c6 into main Apr 14, 2023
@inigomarquinez inigomarquinez deleted the refactor-publishers branch April 14, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Betisman Betisman Betisman approved these changes

@totegsito totegsito totegsito approved these changes

Assignees

@inigomarquinez inigomarquinez

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inigomarquinez @Betisman @totegsito