Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-grained scopes (9.14) tests fail if OperationOutcomes are present #552

Closed
jwjahns opened this issue Aug 21, 2024 · 1 comment
Closed
Labels
bug This is a bug in Inferno g10-test-kit This issue affects onc-certification-g10-test-kit smart-app-launch-test-kit This issue affects smart-app-launch-test-kit v6.0.2 Release v6.0.2

Comments

@jwjahns
Copy link

jwjahns commented Aug 21, 2024

Hello,

The 9.14 tests that check whether data is filtered correctly appear to not handle OperationOutcomes.

From a private Inferno deployment (running g10 test kit v6.0.0):
image

This FHIR ID comes from an OperationOutcome:
image

If I follow the code correctly, that's because the test calls fetch_all_bundled_resources, which returns all resource types present in the Bundle:
https://github.com/inferno-framework/us-core-test-kit/blob/14dd3bf3035dc95d893b44d081ef1368e26549dd/lib/us_core_test_kit/granular_scope_search_test.rb#L31

However, mismatched_resource_ids only throws out resources that don't match a granular scope for the resource under test. So, OperationOutcomes (or any other resource beyond the one under test) will never be thrown out.
https://github.com/inferno-framework/us-core-test-kit/blob/14dd3bf3035dc95d893b44d081ef1368e26549dd/lib/us_core_test_kit/granular_scope_search_test.rb#L89C5-L97C8

(if I follow right, this is technically an issue in us-core-test-kit code, but I assume it's preferred to post these here)

@Jammjammjamm Jammjammjamm added will fix Issue is planned to be addressed in future release bug This is a bug in Inferno labels Aug 26, 2024
@Jammjammjamm
Copy link
Contributor

That does look like what is happening. Thank you for reporting this, we will fix it.

@yunwwang yunwwang added g10-test-kit This issue affects onc-certification-g10-test-kit smart-app-launch-test-kit This issue affects smart-app-launch-test-kit resolved Fix is approved and merged. Working ticket closed and removed will fix Issue is planned to be addressed in future release labels Sep 3, 2024
@yunwwang yunwwang added v6.0.2 Release v6.0.2 and removed resolved Fix is approved and merged. Working ticket closed labels Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is a bug in Inferno g10-test-kit This issue affects onc-certification-g10-test-kit smart-app-launch-test-kit This issue affects smart-app-launch-test-kit v6.0.2 Release v6.0.2
Projects
None yet
Development

No branches or pull requests

3 participants