Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inferno Provenance validation test failed when resource does not have agent.who.reference (FI-2790) #514

Closed
yunwwang opened this issue May 28, 2024 · 0 comments
Closed

Inferno Provenance validation test failed when resource does not have agent.who.reference (FI-2790) #514

yunwwang opened this issue May 28, 2024 · 0 comments
Labels
bug This is a bug in Inferno g10-test-kit This issue affects onc-certification-g10-test-kit us-core-test-kit This issue affects us-core-test-kit v5.4.1 Release v5.4.1

Comments

@yunwwang
Copy link
Contributor

US Core Provenance Profile mandate server populate agent.who.reference. When server does not do that, instead of raising an error, Inferno Provenance validation test throws purple error:

undefined method `reference' for nil:NilClass

      ['Practitioner', 'Device'].any? { |resource_type| agent.who.reference&.include?(resource_type) } &&

This is caused by the resource provided does not have agent.who.reference.

Though the bug does not affect testing result, ie agent.who.reference is missing, we still should fix the purple error with a correct error message.
@yunwwang yunwwang added g10-test-kit This issue affects onc-certification-g10-test-kit us-core-test-kit This issue affects us-core-test-kit bug This is a bug in Inferno labels May 28, 2024
@yunwwang yunwwang changed the title Inferno Provenance validation test failed when resource does not have agent.who.reference Inferno Provenance validation test failed when resource does not have agent.who.reference (FI-2790) May 28, 2024
@yunwwang yunwwang added the will fix Issue is planned to be addressed in future release label May 28, 2024
@yunwwang yunwwang mentioned this issue May 29, 2024
Merged
@yunwwang yunwwang added resolved Fix is approved and merged. Working ticket closed and removed will fix Issue is planned to be addressed in future release labels May 30, 2024
@yunwwang yunwwang added v5.4.1 Release v5.4.1 and removed resolved Fix is approved and merged. Working ticket closed labels Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This is a bug in Inferno g10-test-kit This issue affects onc-certification-g10-test-kit us-core-test-kit This issue affects us-core-test-kit v5.4.1 Release v5.4.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yunwwang