Fixes Snackbar spam pile up (#160)

Author: jLynx

app/src/main/java/com/omkarmoghe/pokemap/views/LoginActivity.java

@@ -131,11 +131,11 @@ public void onClick(View view) {
         mPasswordView.setOnEditorActionListener(new TextView.OnEditorActionListener() {
             @Override
             public boolean onEditorAction(TextView textView, int id, KeyEvent keyEvent) {
-            if (id == R.id.login || id == EditorInfo.IME_NULL) {
-                validatePTCLoginForm();
-                return true;
-            }
-            return false;
+                if (id == R.id.login || id == EditorInfo.IME_NULL) {
+                    validatePTCLoginForm();
+                    return true;
+                }
+                return false;
             }
         });
 

app/src/main/java/com/omkarmoghe/pokemap/views/MainActivity.java

@@ -138,11 +138,13 @@ public void onEvent(LoginEventResult result) {
     public void onEvent(SearchInPosition event) {
         SearchParams params = new SearchParams(SearchParams.DEFAULT_RADIUS * 3, new LatLng(event.getPosition().latitude, event.getPosition().longitude));
         List<LatLng> list = params.getSearchArea();
+        MapWrapperFragment.pokeSnackbar.setText("Searching...");
+        MapWrapperFragment.pokeSnackbar.show();
+        MapWrapperFragment.pokemonFound = 0;
+        MapWrapperFragment.positionNum = 0;
         for (LatLng p : list) {
             nianticManager.getMapInformation(p.latitude, p.longitude, 0D);
         }
-
-
     }
 
     /**

app/src/main/java/com/omkarmoghe/pokemap/views/map/MapWrapperFragment.java

@@ -68,8 +68,8 @@
  * create an instance of this fragment.
  */
 public class MapWrapperFragment extends Fragment implements OnMapReadyCallback,
-                                                            GoogleMap.OnMapLongClickListener,
-                                                            ActivityCompat.OnRequestPermissionsResultCallback {
+        GoogleMap.OnMapLongClickListener,
+        ActivityCompat.OnRequestPermissionsResultCallback {
 
     private static final int LOCATION_PERMISSION_REQUEST = 19;
 
@@ -85,6 +85,10 @@ public class MapWrapperFragment extends Fragment implements OnMapReadyCallback,
     private HashMap<String, PokemonMarkerExtended> markerList = new HashMap<>();
     private HashMap<String, PokestopMarkerExtended> pokestopsList = new HashMap<>();
 
+    public static Snackbar pokeSnackbar;
+    public static int pokemonFound = 0;
+    public static int positionNum = 0;
+
     public MapWrapperFragment() {
         // Required empty public constructor
     }
@@ -179,6 +183,7 @@ public void onClick(View view) {
     }
 
     private void initMap() {
+        pokeSnackbar = Snackbar.make(getView(), "", Snackbar.LENGTH_LONG);
         if (mLocation != null && mGoogleMap != null) {
             if (ContextCompat.checkSelfPermission(mView.getContext(), Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED
                     || ContextCompat.checkSelfPermission(mView.getContext(), Manifest.permission.ACCESS_COARSE_LOCATION) != PackageManager.PERMISSION_GRANTED) {
@@ -276,10 +281,10 @@ private void setPokestopsMarkers(final Collection<Pokestop> pokestops){
     }
 
     private void setPokemonMarkers(final List<CatchablePokemon> pokeList){
+        positionNum++;
         if (mGoogleMap != null) {
 
             Set<String> markerKeys = markerList.keySet();
-            int pokemonFound = 0;
             for (final CatchablePokemon poke : pokeList) {
 
                 if(!markerKeys.contains(poke.getSpawnPointId())) {
@@ -308,8 +313,17 @@ public void onResourceReady(Bitmap bitmap, GlideAnimation anim) {
                 }
             }
             if(getView() != null) {
-                String text = pokemonFound > 0 ? pokemonFound + " new catchable Pokemon have been found." : "No new Pokemon have been found.";
-                Snackbar.make(getView(), text, Snackbar.LENGTH_SHORT).show();
+                if(positionNum != LOCATION_PERMISSION_REQUEST) {
+                    String text = " Searching...." + pokemonFound + " Pokemon found";
+                    pokeSnackbar.setText(text);
+                    pokeSnackbar.show();
+
+                }
+                else {
+                    String text = pokemonFound > 0 ? pokemonFound + " new catchable Pokemon have been found." : "No new Pokemon have been found.";
+                    pokeSnackbar.setText(text);
+                    pokeSnackbar.show();
+                }
             }
             updateMarkers();
         } else {
@@ -392,7 +406,6 @@ public void onMapReady(GoogleMap googleMap) {
         mGoogleMap.setOnMapLongClickListener(this);
         //Disable for now coz is under FAB
         settings.setMapToolbarEnabled(false);
-        initMap();
     }
 
     @Override
@@ -407,41 +420,41 @@ public void onMapLongClick(LatLng position) {
     }
 
     private void drawMarkerWithCircle(LatLng position){
-            if (mGoogleMap != null) {
+        if (mGoogleMap != null) {
 
 
-                //Check and eventually remove old marker
-                if (userSelectedPositionMarker != null && userSelectedPositionCircles != null) {
-                    userSelectedPositionMarker.remove();
-                    for (Circle circle : userSelectedPositionCircles) {
-                        circle.remove();
-                    }
-                    userSelectedPositionCircles.clear();
+            //Check and eventually remove old marker
+            if (userSelectedPositionMarker != null && userSelectedPositionCircles != null) {
+                userSelectedPositionMarker.remove();
+                for (Circle circle : userSelectedPositionCircles) {
+                    circle.remove();
                 }
+                userSelectedPositionCircles.clear();
+            }
 
-                if(mPref.getShowScannedPlaces()) {
-                    double radiusInMeters = 100.0;
-                    int strokeColor = 0x4400CCFF; // outline
-                    int shadeColor = 0x4400CCFF; // fill
+            if(mPref.getShowScannedPlaces()) {
+                double radiusInMeters = 100.0;
+                int strokeColor = 0x4400CCFF; // outline
+                int shadeColor = 0x4400CCFF; // fill
 
-                    SearchParams params = new SearchParams(SearchParams.DEFAULT_RADIUS * 3, new LatLng(position.latitude, position.longitude));
-                    List<LatLng> list = params.getSearchArea();
-                    for (LatLng p : list) {
-                        CircleOptions circleOptions = new CircleOptions().center(new LatLng(p.latitude, p.longitude)).radius(radiusInMeters).fillColor(shadeColor).strokeColor(strokeColor).strokeWidth(8);
-                        userSelectedPositionCircles.add(mGoogleMap.addCircle(circleOptions));
+                SearchParams params = new SearchParams(SearchParams.DEFAULT_RADIUS * 3, new LatLng(position.latitude, position.longitude));
+                List<LatLng> list = params.getSearchArea();
+                for (LatLng p : list) {
+                    CircleOptions circleOptions = new CircleOptions().center(new LatLng(p.latitude, p.longitude)).radius(radiusInMeters).fillColor(shadeColor).strokeColor(strokeColor).strokeWidth(8);
+                    userSelectedPositionCircles.add(mGoogleMap.addCircle(circleOptions));
 
-                    }
                 }
-
-                userSelectedPositionMarker = mGoogleMap.addMarker(new MarkerOptions()
-                        .position(position)
-                        .title("Position Picked")
-                        .icon(BitmapDescriptorFactory.fromBitmap(BitmapFactory.decodeResource(getContext().getResources(),
-                                R.drawable.ic_my_location_white_24dp)))
-                        .anchor(0.5f, 0.5f));
-            } else {
-                showMapNotInitializedError();
             }
+
+            userSelectedPositionMarker = mGoogleMap.addMarker(new MarkerOptions()
+                    .position(position)
+                    .title("Position Picked")
+                    .icon(BitmapDescriptorFactory.fromBitmap(BitmapFactory.decodeResource(getContext().getResources(),
+                            R.drawable.ic_my_location_white_24dp)))
+                    .anchor(0.5f, 0.5f));
+        } else {
+            showMapNotInitializedError();
+        }
     }
 
 }