fix: slow test exceed circle ci timeout limit #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boolafish
force-pushed
the
boolafish/fix_slow_test
branch
from
fb82170
to
fb0f663
Compare
kevsul
previously approved these changes
Mar 10, 2020
pik694
previously approved these changes
Mar 10, 2020
boolafish
force-pushed
the
boolafish/fix_slow_test
branch
from
fb0f663
to
8227e45
Compare
kevsul
previously approved these changes
Mar 10, 2020
pik694
previously approved these changes
Mar 10, 2020
| @@ -144,7 +144,7 @@ jobs: | |||
| - run: | |||
| name: Run slow tests | |||
| working_directory: ~/repo/plasma_framework/python_tests | |||
| no_output_timeout: 10h | |||
| no_output_timeout: 5h # Circl CI limits to 5hr max: https://discuss.circleci.com/t/job-times-out-after-5-hours/32220/3 | |||
There was a problem hiding this comment.
Actually, this setting has little to do with the job timeout itself, since each iteration prints sth to stdout.
There was a problem hiding this comment.
ah, you're right. I remove the no_output_timeout to not confuse anymore.
There was a problem hiding this comment.
okay...that is a bad decision to remove it totally as 10 minutes defaults seems not enough
Long running test is failing after around 3~400 iterations. It is failing due to timeout. This commit tries to increase the timeout period of web3 to see if it helps. issue: #558 ref: https://gitter.im/pipermerriam/web3.py?at=58fe1da7cfec9192726dbdcd
boolafish
force-pushed
the
boolafish/fix_slow_test
branch
from
8227e45
to
3f58cc6
Compare
boolafish
force-pushed
the
boolafish/fix_slow_test
branch
from
5b13d9b
to
3f58cc6
Compare
kevsul
approved these changes
Mar 11, 2020
pik694
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
closes #558
Test
enabled on CI temporary: https://app.circleci.com/jobs/github/omisego/plasma-contracts/10514