Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape transforms not considered when loading ROIs #358

Open
knabar opened this issue Dec 20, 2019 · 0 comments
Open

Shape transforms not considered when loading ROIs #358

knabar opened this issue Dec 20, 2019 · 0 comments

Comments

@knabar
Copy link
Member

knabar commented Dec 20, 2019

When loading ROIs from OMERO that have shape transformations, the transformations are not applied, which results in them being displayed at incorrect positions or not at all.

As an example, the following image has a couple of rectangle shapes, which are shown correctly using Image viewer:

Screenshot 2019-12-20 at 10 36 52

When loading them in Figure, the following data is loaded; note the X/Y coordinates and Transform:

Screenshot 2019-12-20 at 10 33 07

When adding the rectangle in Figure, the following error is shown:

Screenshot 2019-12-20 at 10 32 47

While this is an extreme example, since X/Y/Transform here could be recalculated so that X/Y is still a point on the rectangle, there is no guarantee some tools won't come up with transformations and resulting coordinates that appear to be outside of the image bounds but are not after the transformation is applied.

The export script already takes rectangle transformations into account, see #306, #315, although transformations for other shape types are probably not applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant