Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for version 0.5 of OME-Zarr #88

Open
6 tasks
dstansby opened this issue Dec 17, 2024 · 2 comments
Open
6 tasks

Support for version 0.5 of OME-Zarr #88

dstansby opened this issue Dec 17, 2024 · 2 comments
Labels
v0.5 spec zarr v3 Requires support for zarr v3 in pydantic-zarr

Comments

@dstansby
Copy link
Collaborator

dstansby commented Dec 17, 2024

This is an issue to track implementing version 0.5 of the spec. The plan is to open several sub-issues to track changes that need to be made.

@will-moore
Copy link

Hi @dstansby - I was just testing a tool to generate TypeScript types from Pydantic - see https://github.com/marketplace/actions/pydantic-to-typescript

When I ran it on the _v05 classes...

$ pydantic2ts --module src/ome_zarr_models/_v05/image.py --output image05.ts

It gave me a Multiscale with version?: "0.4" | null; and I also don't see the "version": "0.5" which is required on ImageAttrs I think?

Apologies if this is already on your radar but I didn't recognise it in the issues above. Thanks.

/**
 * Model for the metadata of OME-Zarr data.
 *
 * See https://ngff.openmicroscopy.org/0.4/#image-layout.
 */
export interface ImageAttrs {
  /**
   * The multiscale datasets for this image
   *
   * @minItems 1
   */
  multiscales: [Multiscale, ...Multiscale[]];
  omero?: Omero | null;
  [k: string]: unknown;
}
/**
 * An element of multiscales metadata.
 */
export interface Multiscale {
  axes: Axis[];
  /**
   * @minItems 1
   */
  datasets: [Dataset, ...Dataset[]];
  version?: "0.4" | null;
  coordinateTransformations?: [unknown] | [unknown, unknown] | null;
  metadata?: {
    [k: string]: unknown;
  };
  name?: JsonValue | null;
  type?: {
    [k: string]: unknown;
  };
  [k: string]: unknown;
}

@dstansby
Copy link
Collaborator Author

dstansby commented Feb 4, 2025

Thanks - I opened a new issue because that makes it a bit easier to keep track fixing.

@dstansby dstansby added the zarr v3 Requires support for zarr v3 in pydantic-zarr label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v0.5 spec zarr v3 Requires support for zarr v3 in pydantic-zarr
Projects
None yet
Development

No branches or pull requests

2 participants