Feature request: Sourcemaps support

[jpzwarte]

ng-annotate lacks support for (inline) sourcemaps. Pointed here from gulp-ng-annotate: Kagami/gulp-ng-annotate#3

Nicest solution would be to update inline sourcemaps similar to autoprefixer: https://github.com/ai/autoprefixer#source-map ?

[olov]

Yup. I will be happy merge a source maps PR!

[efolio]

👍 Need! 

[qraynaud]

👍

[smrq]

I have a mostly working implementation for basic sourcemaps. (No merging of existing sourcemaps, at least for now. gulp-ng-annotate should be able to handle that at least) I'll try and clean it up for a PR!

[olov]

Merged and will be part of 0.9.9

[Kagami]

👍

[olov]

0.9.9 is released

[jpzwarte]

Thanks!

[johnpapa]

Does this support sourcemaps created using gulp/grunt where we concat, ngannotate, and uglify and add sourcemaps? I'm seeing the line numbers being off in chrome.

[mgol]

@johnpapa No, AFAIK it doesn't consume input source maps for now.

[olov]

Re incorrect line numbers, can you please open an issue with test data?

I will merge further improvements to source maps, especially input support. Keep those PR's coming! =)

[luckylooke]

Same as @johnpapa.
My use:
gulp.task('scripts', function() {
return gulp.src(['src/*/.js'])
.pipe(jshint('.jshintrc'))
.pipe(sourcemaps.init())
.pipe(concat('main.js'))
.pipe(ngAnotate())
.pipe(uglify())
.pipe(sourcemaps.write())
.pipe(gulp.dest('dist/scripts'));
});

ngAnotate = require('gulp-ng-annotate'),
uglify = require('gulp-uglify'),
jshint = require('gulp-jshint'),
concat = require('gulp-concat'),
sourcemaps = require('gulp-sourcemaps');

chrome developer tools points me to different file and place in it :/

Without ng-annotate it works correctly! :/

[smrq]

I'm currently looking into this. I think it has something to do with the file and/or sources properties of the incoming and/or generated sourcemaps. gulp-ng-annotate uses vinyl-sourcemaps-apply which uses SourceMapGenerator.prototype.applySourceMap from source-map. That relies on filenames to do the correct mappings, which potentially gets tricky with a gulp-based workflow because there aren't real intermediate files.

You can see what's going on with your particular files by visualizing the sourcemap output using this tool: http://sokra.github.io/source-map-visualization/

[b-long]

Is anyone using Kagami/gulp-ng-annotate ? If so, would you mind sharing an example Gulpfile & package.json?