-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for webpack2 native es6 import feature #227
Comments
ES6 support in ng-annotate will only happen if a contributor steps up. It terms of combining ng-annotate with other tools, you should perform ng-annotate processing after more or less everything else, but before you minify. As long as you use the |
@olov can we then reopen the issue and add a |
There is no open "Add support for ES6 (and ES2016, and..) [contributions-welcome]" issue open because, like so many other things, it's a tradeoff (complexity and more code for someone to maintain). It seems to me that your particular issue is caused by your current webpack configuration, as I suggested in my previous comment. |
It's less about supporting everything from ES6, than to avoid to break on import and export ES6 statements. I can't tell why this happens, but I confirm the issue of the OP. And changing Babel from es2015-webpack to es2015 will make it working. So it's all about |
Btw, this is the error thrown: |
it would be nice if ng-annotate support the native es import feature (so we dont have to rely on commonjs modules).
this feature enables us to use tree-shaking (to remove useless code) http://www.2ality.com/2015/12/webpack-tree-shaking.html
also see andrey-skl/ng-annotate-loader#17
The text was updated successfully, but these errors were encountered: