Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL broken on iOS 11 #396

Open
oliviertassinari opened this issue Nov 27, 2017 · 4 comments
Open

RTL broken on iOS 11 #396

oliviertassinari opened this issue Nov 27, 2017 · 4 comments

Comments

@oliviertassinari
Copy link
Owner

oliviertassinari commented Nov 27, 2017

It seems to be a iOS 11 regression. It's working fine with iOS 10. I have no clue about what's wrong.

@oliviertassinari oliviertassinari changed the title RTL broken on iOS RTL broken on iOS 11 Nov 27, 2017
@necolas
Copy link

necolas commented Nov 28, 2017

Have you looked into implementing this package on top of the react native API (for web and native)? That provides APIs for RTL and more, as well as being where the (up-to-date) implementation of Animated lives

@oliviertassinari
Copy link
Owner Author

@necolas I have done two tentatives of implementing the library under this folder for react-native. I have lost interest in react-native recently, but I'm eager to unify the implementation! Actually, it's what motived #378. What would be for me the best way to try out those two implementations with react-native-web? By the way, I'm also wondering if we don't have the opportunity to build a cross-platform material design library.

@necolas
Copy link

necolas commented Nov 28, 2017

What would be for me the best way to try out those two implementations with react-native-web?

I'd probably start with whatever code is maintained, isolate any use of DOM APIs and then replace them with equivalent RN APIs. If some APIs can't be replaced, they can live in a separate .web.js file with a native equivalent in .native.js.

I'm also wondering if we don't have the opportunity to build a cross-platform material design library

Yeah we previously discussed that here:
mui/material-ui#593

And this is another attempt that could be made to work on web with RNW:
https://github.com/callstack/react-native-paper

I'm biased, but my experience building Twitter for Web makes me think all React components (for web or native) should now be implemented using the core RN APIs/Components. It provides many of the building blocks that component libraries end up trying to make themselves, but anything built on RN can easily interop with other things built on RN.

@yinsang
Copy link

yinsang commented Jan 5, 2018

WebkitOverflowScrolling: 'touch' may lead to iOS 11 broken. Wish you can have some ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants