Skip to content
This repository has been archived by the owner on Jul 11, 2019. It is now read-only.

NPM distribution missing ES module build #94

Open
petermikitsh opened this issue Oct 4, 2018 · 3 comments
Open

NPM distribution missing ES module build #94

petermikitsh opened this issue Oct 4, 2018 · 3 comments

Comments

@petermikitsh
Copy link

The rollup config references a module build, however...

https://unpkg.com/react-event-listener@0.6.4/dist/react-event-listener.esm.js does not exist
https://unpkg.com/react-event-listener@0.6.4/dist/react-event-listener.cjs.js exists

@TrySound
Copy link
Contributor

TrySound commented Oct 4, 2018

This package is used by material-ui which is distributed only with cjs. Webpack is not able to handle a few cases with cjs/esm interop. There is a solution but Oliver doesn't feel good about named exports.
#79

Default exports suck. I wish they don't exist.

@petermikitsh
Copy link
Author

Should the module build be removed from the rollup config then?

@TrySound
Copy link
Contributor

TrySound commented Oct 4, 2018

I would leave it for better times.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants